Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm - allow loading all river files in a folder #6579

Closed
wants to merge 5 commits into from

Conversation

fculpo
Copy link

@fculpo fculpo commented Mar 1, 2024

PR Description

This PR implements this cli feature: #5228

When using a user provided configMap containing multiple river files, files are mounted to /etc/agent, but the chart only allowed to load a single entrypoint river. This behaviour, even with modules, makes overrides or unloading components in some clusters difficult when using a common configuration.

This PR enables loading all river files in /etc/agent (a la terraform). Configmap can then be overridden in some env by not loading some files or only modifying the needed one.

Which issue(s) this PR fixes

Fixes grafana/alloy#228

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2024

CLA assistant check
All committers have signed the CLA.

@fculpo fculpo force-pushed the load-folder branch 4 times, most recently from 19f5fcc to b571a32 Compare March 4, 2024 13:44
@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 12, 2024
@fculpo fculpo closed this Jun 11, 2024
@fculpo fculpo deleted the load-folder branch June 11, 2024 08:01
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Jul 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. needs-attention An issue or PR has been sitting around and needs attention. variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow helm chart to load all river files in volumemount
3 participants