Add build image for windows boringcrypto executable. #6369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note I have built a fips windows version using my docker account mrdgrafana build image. |
|
I originally though about importing the core build image and only overwriting the go parts but then the build image needs to have another step and that seems painful. Basically would have to trigger a build on the normal build images, change the code for fips to use them, then trigger another build for the fips image. |
rfratto
reviewed
Feb 16, 2024
…d_image' into create_windows_boringcrypto_build_image
…d_image' into create_windows_boringcrypto_build_image
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* Add build image for windows boringcrypto executable. * Update Dockerfile * Update build_image.jsonnet * Use ARG instead of duplicate image * force the usage of arg
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This lays the groundwork for building windows agent flow using boring crypto. The important bit for this is
FROM mcr.microsoft.com/oss/go/microsoft/golang:1.22-bullseye as golangwhich tells it to use the fips compatible windows golang runtime.Not adding a changelog until the second part of the pr to use the built image.
At some point may switch the linux version to using this so its cleaner on what builds what.