Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pyroscope/scrape): remove unused path_prefix argument #6334

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hainenber
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Closes grafana/alloy#263

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated

@ptodev
Copy link
Contributor

ptodev commented Feb 9, 2024

I asked about this in a comment, but @cyriltovena mentioned that if it doesn't work then that'd be a bug and it'd be worth fixing.

@hainenber hainenber marked this pull request as ready for review February 17, 2024 08:26
@hainenber hainenber requested review from a team and clayton-cornell as code owners February 17, 2024 08:26
@tpaschalis
Copy link
Member

I'd also +1 trying to wire this in instead.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 20, 2024
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Mar 22, 2024
@rfratto rfratto added the variant/flow Relatd to Grafana Agent Flow. label Apr 9, 2024
@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Apr 12, 2024
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-attention An issue or PR has been sitting around and needs attention. type/docs Docs Squad label across all Grafana Labs repos variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused path_prefix config argument for pyroscope.scrape
5 participants