Add metrics and resource attribute config options from vcentereceiver in docs and tests #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
approved these changes
Nov 20, 2023
ptodev
reviewed
Nov 20, 2023
Comment on lines
187
to
188
| require.Equal(t, false, otelArgs.Metrics.VcenterClusterCPUEffective.Enabled) | ||
| require.Equal(t, true, otelArgs.Metrics.VcenterClusterCPULimit.Enabled) |
There was a problem hiding this comment.
Suggested change
| require.Equal(t, false, otelArgs.Metrics.VcenterClusterCPUEffective.Enabled) | |
| require.Equal(t, true, otelArgs.Metrics.VcenterClusterCPULimit.Enabled) | |
| require.False(t, otelArgs.Metrics.VcenterClusterCPUEffective.Enabled) | |
| require.True(t, otelArgs.Metrics.VcenterClusterCPULimit.Enabled) |
I think this is clearer, but I'm happy if you leave it as it is.
ptodev
reviewed
Nov 20, 2023
docs/sources/flow/reference/components/otelcol.receiver.vcenter.md
Outdated
Show resolved
Hide resolved
…r.md Co-authored-by: Paulin Todev <[email protected]>
ptodev
reviewed
Nov 20, 2023
| @@ -92,6 +96,77 @@ isn't provided, TLS won't be used for connections to the server. | |||
|
|
|||
| {{< docs/shared lookup="flow/reference/components/otelcol-tls-config-block.md" source="agent" version="<AGENT VERSION>" >}} | |||
|
|
|||
| ### metrics block | |||
|
|
|||
| Name | Type | Description | Default | Required | |||
There was a problem hiding this comment.
Do you mind making metric in the Type column a hyperlink to #### metric block please?
BTW After we get consensus on #5764, I might need to rework this doc to be in line with that future desicion.
ptodev
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
LGTM. You could address the hyperlink comment and the other comments from #5715 in a separate PR. I think the docs now look pretty good for a first release 👌
grafanabot
pushed a commit
that referenced
this pull request
Nov 21, 2023
… in docs and tests (#5813) Co-authored-by: Paulin Todev <[email protected]> (cherry picked from commit 6c028c0)
clayton-cornell
pushed a commit
that referenced
this pull request
Nov 21, 2023
… in docs and tests (#5813) (#5825) Co-authored-by: Paulin Todev <[email protected]> (cherry picked from commit 6c028c0) Co-authored-by: Marc Tudurí <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
After merging #5715 we identified a couple of things to be done in a follow up PR.
This PR adds the missing configurable fields from vcenter receiver to its documentations site.
It also adds case scenarios for config conversion.
PR Checklist