feat(otelcol/exp/prom): add support for resource_to_telemetry_conversion #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/sources/flow/reference/components/otelcol.exporter.prometheus.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
|
Thanks @hainenber! @ptodev Can you review this one? |
ptodev
approved these changes
Nov 24, 2023
| test_metric_gauge{bar_one="bar",foo_one="foo",instance="instance",service_instance_id="instance",job="myservice",service_name="myservice",raw="test"} 1234.56 | ||
| `, | ||
| enableOpenMetrics: true, | ||
| resourceToTelemetryConversion: true, |
There was a problem hiding this comment.
It'd be nice to have a test or two where we have resource attributes but resourceToTelemetryConversion: false
There was a problem hiding this comment.
Added in latest commit. PTAL. Thanks!
docs/sources/flow/reference/components/otelcol.exporter.prometheus.md
Outdated
Show resolved
Hide resolved
Signed-off-by: hainenber <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
…heus.md Co-authored-by: Paulin Todev <[email protected]>
…is false Signed-off-by: hainenber <[email protected]>
hainenber
force-pushed
the
support-resource-to-telemetry-conversion
branch
from
65df9d7 to
4077196
Compare
ptodev
reviewed
Nov 27, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Support conversion of OTEL's resource attributes to Prometheus-compatible datapoint attributes. Strongly inspired by OTEL's contributor implementation
Which issue(s) this PR fixes
Closes #5631
Notes to the Reviewer
PR Checklist