Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging issue #5752

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix logging issue #5752

merged 1 commit into from
Nov 10, 2023

Conversation

thampiotr
Copy link
Contributor

@thampiotr thampiotr commented Nov 10, 2023

PR Description

The recent unreleased change to the logging library had a bug where in some cases the log lines would be reported as INFO, regardless of the level set.

This PR fixes this issue and adds tests.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • Tests updated

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@thampiotr thampiotr marked this pull request as ready for review November 10, 2023 14:44
@thampiotr thampiotr requested a review from a team as a code owner November 10, 2023 14:44
@thampiotr thampiotr merged commit 70f8e95 into main Nov 10, 2023
10 checks passed
@thampiotr thampiotr deleted the thampiotr/fix-logging-bug branch November 10, 2023 14:47
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants