Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong order of exemplars vs samples #5750

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Conversation

krajorama
Copy link
Contributor

PR Description

Port of prometheus/prometheus#13113

Which issue(s) this PR fixes

N/A

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krajorama Can you add a CHANGELOG.md entry for this as a bugfix before we merge?

Signed-off-by: György Krajcsovits <[email protected]>
@krajorama
Copy link
Contributor Author

Thanks!

@krajorama Can you add a CHANGELOG.md entry for this as a bugfix before we merge?

Updated changelog. I've tried to use the same style as the others, but this is my first in agent :)

Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tpaschalis tpaschalis enabled auto-merge (squash) November 14, 2023 09:52
@tpaschalis tpaschalis merged commit 97b6b8f into main Nov 14, 2023
10 checks passed
@tpaschalis tpaschalis deleted the krajo/fix-wal-wrong-order branch November 14, 2023 10:13
krajorama added a commit to grafana/mimir that referenced this pull request Nov 27, 2023
Due to grafana/agent#5750

Signed-off-by: György Krajcsovits <[email protected]>
krajorama added a commit to grafana/mimir that referenced this pull request Nov 27, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants