Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agentctl): set exit code 1 on non-runnable command #5717

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix(agentctl): set exit code 1 on non-runnable command #5717

merged 1 commit into from
Nov 10, 2023

Conversation

fgouteroux
Copy link
Contributor

PR Description

Set exit code 1 (instead of 0) on grafana-agentctl non-runnable command.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@fgouteroux fgouteroux requested a review from a team as a code owner November 6, 2023 15:40
wildum
wildum approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto merged commit 867910b into grafana:main Nov 10, 2023
10 checks passed
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wildum wildum wildum approved these changes

Assignees

@wildum wildum

Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgouteroux @wildum @rfratto