Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope.ebpf update dependency to include python unicode fix #5702

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

korniltsev
Copy link
Contributor

@korniltsev korniltsev commented Nov 3, 2023

PR Description

This fixes python profiling when there are non ascii function names or file names or class names
See grafana/pyroscope#2622

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@korniltsev korniltsev requested a review from a team as a code owner November 3, 2023 08:23
@korniltsev korniltsev enabled auto-merge (squash) November 3, 2023 08:23
@rfratto
Copy link
Member

rfratto commented Nov 3, 2023

@korniltsev It sounds like this should be mentioned in our CHANGELOG as a bugfix, can you add an entry?

@korniltsev korniltsev merged commit 877862e into main Nov 9, 2023
10 checks passed
@korniltsev korniltsev deleted the pyroscope-ebpf-fixes branch November 9, 2023 07:38
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants