-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Kubernetes service resolver to loadbalancing exporters. #5678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion for the docs
docs/sources/flow/reference/components/otelcol.exporter.loadbalancing.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but personally I still think the block should be called kubernetes
instead of k8s
.
…lancing.md Co-authored-by: Clayton Cornell <[email protected]>
889e35a
to
fd9a1ed
Compare
I agree, and I've happily added it to the PR. Thank you for the review! 🚢 |
PR Description
This feature was added to Collector version v0.82.0, but it looks like we didn't update the components on our end to use it.
PR Checklist