Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kubernetes service resolver to loadbalancing exporters. #5678

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Nov 1, 2023

PR Description

This feature was added to Collector version v0.82.0, but it looks like we didn't update the components on our end to use it.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@ptodev ptodev requested review from a team and clayton-cornell as code owners November 1, 2023 13:33
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion for the docs

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Nov 1, 2023
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but personally I still think the block should be called kubernetes instead of k8s.

@rfratto rfratto self-assigned this Nov 14, 2023
@ptodev ptodev force-pushed the ptodev/add-k8s-resolver-to-lb branch from 889e35a to fd9a1ed Compare November 14, 2023 16:30
@ptodev
Copy link
Contributor Author

ptodev commented Nov 14, 2023

LGTM, but personally I still think the block should be called kubernetes instead of k8s.

I agree, and I've happily added it to the PR. Thank you for the review! 🚢

@ptodev ptodev merged commit 94447c5 into main Nov 14, 2023
10 checks passed
@ptodev ptodev deleted the ptodev/add-k8s-resolver-to-lb branch November 14, 2023 20:58
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants