Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] prometheus.exporter.[blackbox, snmp] misc. fixes (#5187) #5221

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

clayton-cornell
Copy link
Contributor

  • Remove name from block arguments and add a sentence that a label is required

  • Fix blocks header levels and move 'period and length' section

  • Add suggested change

Co-authored-by: Clayton Cornell [email protected]

  • Revert "Fix blocks header levels and move 'period and length' section"

This reverts commit 93a593a.


Co-authored-by: Clayton Cornell [email protected]
(cherry picked from commit 31999c8)

PR Description

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

* Remove name from block arguments and add a sentence that a label is required

* Fix blocks header levels and move 'period and length' section

* Add suggested change

Co-authored-by: Clayton Cornell <[email protected]>

* Revert "Fix blocks header levels and move 'period and length' section"

This reverts commit 93a593a.

---------

Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 31999c8)
@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport labels Sep 14, 2023
@clayton-cornell clayton-cornell requested a review from a team September 14, 2023 19:40
Copy link
Contributor

@spartan0x117 spartan0x117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why GH is highlighting the decoupled scraping block section, but I don't see it duplicated

@clayton-cornell clayton-cornell merged commit 0650e0f into release-v0.35 Sep 14, 2023
8 checks passed
@clayton-cornell clayton-cornell deleted the backport-5187-to-release-v0.35 branch September 14, 2023 19:54
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants