component/otelcol: expose randomization_factor and multiplier in retry blocks #5219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y blocks Follow up on grafana#5188.
tpaschalis
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Leaving to @clayton-cornell for the final say, but at least to me it reads well enough.
ptodev
reviewed
Sep 18, 2023
docs/sources/shared/flow/reference/components/otelcol-retry-block.md
Outdated
Show resolved
Hide resolved
|
I find it weird that these two parameters are not documented in the Otel docs either. I asked a question on the CNCF Slack channel whether this is intentional. |
There was a problem hiding this comment.
The rand factor is a bit complicated, but I think the rewrite by @ptodev makes sense in context.
So docs are OK as-is.
…ock.md Co-authored-by: Paulin Todev <[email protected]>
hainenber
pushed a commit
to hainenber/agent
that referenced
this pull request
Sep 23, 2023
…y blocks (grafana#5219) Follow up on grafana#5188. Co-authored-by: Paschalis Tsilias <[email protected]> Co-authored-by: Paulin Todev <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #5188.
I'm not super sure on how to document these new fields clearly, help from @clayton-cornell would be appreciated on this.