Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openstack config converter #5208

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Conversation

wildum
Copy link
Contributor

@wildum wildum commented Sep 14, 2023

PR Description

Although we already had the discovery.openstack flow component, the config converter was missing. This PR is adding it.

Which issue(s) this PR fixes

Fixes #5177

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Tests updated
  • Config converters updated

@wildum wildum requested a review from a team as a code owner September 14, 2023 15:11
@wildum wildum requested a review from a team as a code owner September 18, 2023 09:33
Copy link
Contributor

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch on the tls_config attr vs block

@erikbaranowski erikbaranowski merged commit 2a560c5 into main Sep 18, 2023
@erikbaranowski erikbaranowski deleted the add-openstack-config-converter branch September 18, 2023 14:26
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add openstack config converter
3 participants