Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong order for the split functions example #5198

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Wrong order for the split functions example #5198

merged 1 commit into from
Sep 14, 2023

Conversation

marioanton
Copy link
Contributor

PR Description

Fixes split function documentation.

Which issue(s) this PR fixes

NA

Notes to the Reviewer

Fixes documentation for split function order examples.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

tpaschalis
tpaschalis approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@tpaschalis tpaschalis merged commit cc10190 into grafana:main Sep 14, 2023
@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release-v0.35 backport release-v0.36 labels Sep 14, 2023
@clayton-cornell
Copy link
Contributor

We can backport this to the docs for v0.35 and v0.36

@grafanabot grafanabot mentioned this pull request Sep 14, 2023
Merged
grafanabot pushed a commit that referenced this pull request Sep 14, 2023
@marioanton @grafanabot
Fix order for the split functions example (#5198)
c8fb89a 
(cherry picked from commit cc10190)
@grafanabot grafanabot mentioned this pull request Sep 14, 2023
Merged
grafanabot pushed a commit that referenced this pull request Sep 14, 2023
@marioanton @grafanabot
Fix order for the split functions example (#5198)
a01d41e 
(cherry picked from commit cc10190)
clayton-cornell pushed a commit that referenced this pull request Sep 14, 2023
@grafanabot @marioanton
Fix order for the split functions example (#5198) (#5216)
37cf7f5 
(cherry picked from commit cc10190)

Co-authored-by: marioanton <[email protected]>
clayton-cornell pushed a commit that referenced this pull request Sep 14, 2023
@grafanabot @marioanton
Fix order for the split functions example (#5198) (#5217)
c1d08c4 
(cherry picked from commit cc10190)

Co-authored-by: marioanton <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tpaschalis tpaschalis tpaschalis approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

Assignees
No one assigned
Labels
backport release-v0.35 backport release-v0.36 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marioanton @CLAassistant @clayton-cornell @tpaschalis