-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nil_to_zero
YACE config
#5194
Conversation
Overall looks good but we should add the conversion from static -> flow mode in |
Thanks, I think I've fixed that now. I'm not as familiar with this code so I'm not sure if I could still be missing some places. |
@mattdurham I think the staticconvert code currently skips converting static jobs:
There might be a few other things missing in this converter. |
@mattdurham Is this good to merge now? I fixed the converter so it now correctly converts static jobs. |
Sorry was out Friday, @clayton-cornell can check the docs and then if you can resolve the conflict I will merge. |
Rebased to fix merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change for docs
| Name | Type | Description | Default | Required | | ||
| ------------- | -------------- | ------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------- | -------- | | ||
| `name` | `string` | Metric name. | | yes | | ||
| `statistics` | `list(string)` | List of statistics to scrape. Ex: `"Minimum"`, `"Maximum"`, etc. | | yes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `statistics` | `list(string)` | List of statistics to scrape. Ex: `"Minimum"`, `"Maximum"`, etc. | | yes | | |
| `statistics` | `list(string)` | List of statistics to scrape. For example, `"Minimum"`, `"Maximum"`, etc. | | yes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clayton-cornell I'm fine committing this, but I didn't actually change this text. I had to reformat because the table columns needed to get bigger to support the new row that I added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@berler That's fine. It's just some general cleanup we can do in the doc content - I try to catch these (the e.g. or Ex) when I spot them.
@mattdurham Over to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Description
Adds
nil_to_zero
config flag soYACE
can be configured instead of hard-codingtrue
.Which issue(s) this PR fixes
Fixes #5075
Notes to the Reviewer
PR Checklist