Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nil_to_zero YACE config #5194

Merged
merged 3 commits into from
Sep 18, 2023
Merged

add nil_to_zero YACE config #5194

merged 3 commits into from
Sep 18, 2023

Conversation

berler
Copy link
Contributor

@berler berler commented Sep 14, 2023

PR Description

Adds nil_to_zero config flag so YACE can be configured instead of hard-coding true.

Which issue(s) this PR fixes

Fixes #5075

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@berler berler requested review from a team and clayton-cornell as code owners September 14, 2023 00:31
@mattdurham
Copy link
Collaborator

Overall looks good but we should add the conversion from static -> flow mode in cloudwatch_exporter.go

@berler berler requested a review from a team as a code owner September 14, 2023 18:35
@berler
Copy link
Contributor Author

berler commented Sep 14, 2023

Overall looks good but we should add the conversion from static -> flow mode in cloudwatch_exporter.go

Thanks, I think I've fixed that now. I'm not as familiar with this code so I'm not sure if I could still be missing some places.

@berler
Copy link
Contributor Author

berler commented Sep 14, 2023

@mattdurham I think the staticconvert code currently skips converting static jobs:

-- should I fix this too?

There might be a few other things missing in this converter.

@berler
Copy link
Contributor Author

berler commented Sep 15, 2023

@mattdurham Is this good to merge now? I fixed the converter so it now correctly converts static jobs.

@berler berler changed the title add nil_to_zero YACE config add nil_to_zero YACE config Sep 15, 2023
@mattdurham
Copy link
Collaborator

Sorry was out Friday, @clayton-cornell can check the docs and then if you can resolve the conflict I will merge.

@berler
Copy link
Contributor Author

berler commented Sep 18, 2023

Rebased to fix merge conflicts.

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change for docs

| Name | Type | Description | Default | Required |
| ------------- | -------------- | ------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------- | -------- |
| `name` | `string` | Metric name. | | yes |
| `statistics` | `list(string)` | List of statistics to scrape. Ex: `"Minimum"`, `"Maximum"`, etc. | | yes |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `statistics` | `list(string)` | List of statistics to scrape. Ex: `"Minimum"`, `"Maximum"`, etc. | | yes |
| `statistics` | `list(string)` | List of statistics to scrape. For example, `"Minimum"`, `"Maximum"`, etc. | | yes |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clayton-cornell I'm fine committing this, but I didn't actually change this text. I had to reformat because the table columns needed to get bigger to support the new row that I added.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@berler That's fine. It's just some general cleanup we can do in the doc content - I try to catch these (the e.g. or Ex) when I spot them.

@clayton-cornell
Copy link
Contributor

@mattdurham Over to you.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Sep 18, 2023
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdurham mattdurham merged commit 6e8ab4b into grafana:main Sep 18, 2023
@berler berler deleted the nil-to-zero-yace-config branch September 18, 2023 21:52
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
3 participants