Remove sudo command from RHEL Fedora install instructions #5189
Conversation
clayton-cornell
added
type/docs
(cherry picked from commit 646630c)
(cherry picked from commit 646630c)
(cherry picked from commit 646630c)
| @@ -72,7 +72,6 @@ To install Grafana Agent in static mode on RHEL or Fedora, run the following com | |||
| 1. Create `/etc/yum.repos.d/grafana.repo` with the following content: | |||
|
|
|||
| ```shell | |||
There was a problem hiding this comment.
@aam1r I merged before I saw your comment. Help me understand the reasoning for using ini vs shell (or bash) for the codeblock language here
There was a problem hiding this comment.
My apologies for the lack of explanation.
.repo files use a similar syntax as INI files (see https://en.wikipedia.org/wiki/INI_file). shell is more appropriate for shell commands such as the ones below, whereas ini is more appropriate for this particular configuration change.
Before (shell):
[grafana]
name=grafana
baseurl=https://rpm.grafana.com
repo_gpgcheck=1
enabled=1
gpgcheck=1
gpgkey=https://rpm.grafana.com/gpg.key
sslverify=1
sslcacert=/etc/pki/tls/certs/ca-bundle.crtAfter (ini):
[grafana]
name=grafana
baseurl=https://rpm.grafana.com
repo_gpgcheck=1
enabled=1
gpgcheck=1
gpgkey=https://rpm.grafana.com/gpg.key
sslverify=1
sslcacert=/etc/pki/tls/certs/ca-bundle.crtNotice the better color formatting when using ini 🙂 FYI, this is just a cosmetic change with no impact on the overall instructions.
There was a problem hiding this comment.
Ah cool. For consistency, if I change it here, I'd want to dig through the other places it could also be used. I've got some changes pending/planned for the install docs. I'll give it a try and see how it fits into the existing docs.
(cherry picked from commit 646630c) Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 646630c) Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 646630c) Co-authored-by: Clayton Cornell <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
PR Description
This PR removes a sudo command that slipped into the Linux install instructions for RHEL/Fedora
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist