Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the example syntax in the loki.source.kafka reference topic #5182

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

clayton-cornell
Copy link
Contributor

PR Description

This PR updates the example in https://grafana.com/docs/agent/latest/flow/reference/components/loki.source.kafka/ and adds in a missing forward_to argument, fixes another forward_to destination, and puts the blocks into a more logical/readable order.

Which issue(s) this PR fixes

Fixes #5044

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@clayton-cornell clayton-cornell merged commit fe194f1 into main Sep 13, 2023
10 checks passed
@clayton-cornell clayton-cornell deleted the docs/correct-example-loki.source.kafka branch September 13, 2023 17:57
grafanabot pushed a commit that referenced this pull request Sep 13, 2023
(cherry picked from commit fe194f1)
grafanabot pushed a commit that referenced this pull request Sep 13, 2023
(cherry picked from commit fe194f1)
grafanabot pushed a commit that referenced this pull request Sep 13, 2023
(cherry picked from commit fe194f1)
clayton-cornell added a commit that referenced this pull request Sep 13, 2023
(cherry picked from commit fe194f1)

Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell added a commit that referenced this pull request Sep 13, 2023
(cherry picked from commit fe194f1)

Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell added a commit that referenced this pull request Sep 13, 2023
(cherry picked from commit fe194f1)

Co-authored-by: Clayton Cornell <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.34 backport release-v0.35 backport release-v0.36 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loki.source.kafka Example not working
2 participants