-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the example syntax in the loki.source.kafka reference topic #5182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-cornell
added
type/docs
Docs Squad label across all Grafana Labs repos
backport release-v0.34
backport release-v0.35
backport release-v0.36
labels
Sep 13, 2023
mattdurham
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
grafanabot
pushed a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit fe194f1)
grafanabot
pushed a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit fe194f1)
grafanabot
pushed a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit fe194f1)
clayton-cornell
added a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit fe194f1) Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell
added a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit fe194f1) Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell
added a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit fe194f1) Co-authored-by: Clayton Cornell <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
label
Feb 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport release-v0.34
backport release-v0.35
backport release-v0.36
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
type/docs
Docs Squad label across all Grafana Labs repos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR updates the example in https://grafana.com/docs/agent/latest/flow/reference/components/loki.source.kafka/ and adds in a missing
forward_to
argument, fixes anotherforward_to
destination, and puts the blocks into a more logical/readable order.Which issue(s) this PR fixes
Fixes #5044
Notes to the Reviewer
PR Checklist