-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): switch and bump new version for IBM/sarama
#5180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainenber
force-pushed
the
switch-to-ibm-sarama
branch
from
September 13, 2023 12:17
7667f9f
to
afc1308
Compare
Good catch! Seems there's a couple linter errors to catch, otherwise should be good to go! |
hainenber
force-pushed
the
switch-to-ibm-sarama
branch
from
September 13, 2023 13:12
afc1308
to
fc643f1
Compare
hainenber
force-pushed
the
switch-to-ibm-sarama
branch
from
September 16, 2023 08:34
7910ca8
to
488dec2
Compare
tpaschalis
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Leaving it to @grafana/infra-agent to see if they have any feedback, otherwise I'll be merging this. |
Merging since there's been no feedback from @grafana/infra-agent. |
hainenber
added a commit
to hainenber/agent
that referenced
this pull request
Sep 23, 2023
github-actions
bot
added
the
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
label
Feb 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As the
sarama
module has its ownership transferred to IBM,grafana/agent
should switch to the new URI for ease of upgrade in the feature, either manually or via Dependabot.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist