Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): switch and bump new version for IBM/sarama #5180

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Sep 13, 2023

PR Description

As the sarama module has its ownership transferred to IBM, grafana/agent should switch to the new URI for ease of upgrade in the feature, either manually or via Dependabot.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated

@tpaschalis
Copy link
Member

Good catch! Seems there's a couple linter errors to catch, otherwise should be good to go!

Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tpaschalis
Copy link
Member

Leaving it to @grafana/infra-agent to see if they have any feedback, otherwise I'll be merging this.

@rfratto
Copy link
Member

rfratto commented Sep 22, 2023

Merging since there's been no feedback from @grafana/infra-agent.

@rfratto rfratto merged commit 6458bcd into grafana:main Sep 22, 2023
5 of 6 checks passed
hainenber added a commit to hainenber/agent that referenced this pull request Sep 23, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants