Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discovery.linode component #5174

Merged
merged 11 commits into from
Sep 14, 2023
Merged

discovery.linode component #5174

merged 11 commits into from
Sep 14, 2023

Conversation

captncraig
Copy link
Contributor

@captncraig captncraig commented Sep 12, 2023 •
edited
Loading

Fixes #2274

erikbaranowski
erikbaranowski approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@erikbaranowski erikbaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 nit on docs to consider before merge.

I sanity checked each of the type converters for completeness and readme for arguments/defaults

docs/sources/flow/reference/components/discovery.linode.md Outdated
}
prometheus.scrape "demo" {
targets = discovery.relabel.private_ips.targets
forward_to = [...]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we typically build out the full example in this section although it may be redundant in this case

clayton-cornell
clayton-cornell reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doc suggestions

docs/sources/flow/reference/components/discovery.linode.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/discovery.linode.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/discovery.linode.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/discovery.linode.md Outdated Show resolved Hide resolved
docs/sources/flow/reference/components/discovery.linode.md Outdated Show resolved Hide resolved
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Sep 13, 2023
@captncraig captncraig merged commit 0c708da into main Sep 14, 2023
6 checks passed
@captncraig captncraig deleted the cmp_linode branch September 14, 2023 16:59
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clayton-cornell clayton-cornell clayton-cornell left review comments

@erikbaranowski erikbaranowski erikbaranowski approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flow: discovery.linode component
3 participants
@captncraig @erikbaranowski @clayton-cornell