Add probabilistic sampler processor #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar4uk
force-pushed
the
add-otelcol-probabilistic-sampler-processor
branch
2 times, most recently
from
d2afa4a
to
00f0447
Compare
ptodev
requested changes
Sep 12, 2023
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
component/otelcol/processor/probabilistic_sampler/probabilistic_sampler_test.go
Outdated
Show resolved
Hide resolved
component/otelcol/processor/probabilistic_sampler/probabilistic_sampler_test.go
Outdated
Show resolved
Hide resolved
mar4uk
force-pushed
the
add-otelcol-probabilistic-sampler-processor
branch
from
00f0447
to
5fc1005
Compare
|
Thank you @ptodev for review! I fixed all of you mentioned |
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
mar4uk
force-pushed
the
add-otelcol-probabilistic-sampler-processor
branch
from
1bfa374
to
1f2f274
Compare
|
Thank you @clayton-cornell! I made changes to address all your suggestions |
ptodev
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Thank you, it looks great! I added a few minor suggestions. After @clayton-cornell approves, we could merge it.
component/otelcol/processor/probabilistic_sampler/probabilistic_sampler.go
Show resolved
Hide resolved
docs/sources/flow/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
…robabilistic_sampler
…bilistic_sampler.md Co-authored-by: Clayton Cornell <[email protected]>
mar4uk
force-pushed
the
add-otelcol-probabilistic-sampler-processor
branch
from
5142f4c
to
81d7f8e
Compare
|
Seems there are a few linter errors in the CI |
…c_sampler.go Co-authored-by: Paulin Todev <[email protected]>
mar4uk
force-pushed
the
add-otelcol-probabilistic-sampler-processor
branch
from
81d7f8e
to
f7e42cf
Compare
|
forgot to import river, now linter passes |
clayton-cornell
approved these changes
Sep 14, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
implements a flow component otelcol.processor.probabilistic_sampler that wraps over the upstream OpenTelemetry Collector Contrib probabilistic_sampler processor.
Which issue(s) this PR fixes
#3596
Notes to the Reviewer
PR Checklist