-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify loki source file doesn't handle discovery #4787
Merged
clayton-cornell
merged 3 commits into
grafana:main
from
joshuapare:fix-loki-source-file-docs
Aug 15, 2023
Merged
clarify loki source file doesn't handle discovery #4787
clayton-cornell
merged 3 commits into
grafana:main
from
joshuapare:fix-loki-source-file-docs
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshuapare Looks good. Thanks for your input! Merging.
grafanabot
pushed a commit
that referenced
this pull request
Aug 15, 2023
* clarify loki source file doesn't handle discovery * Update docs/sources/flow/reference/components/loki.source.file.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 883d569)
clayton-cornell
added a commit
that referenced
this pull request
Aug 16, 2023
* clarify loki source file doesn't handle discovery * Update docs/sources/flow/reference/components/loki.source.file.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 883d569) Co-authored-by: Joshua Pare <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport release-v0.35
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
type/docs
Docs Squad label across all Grafana Labs repos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3954
Clarify that
loki.source.file
doesn't handle discovery, and link to the example in the docs that shows usage with the correct component.