Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify loki source file doesn't handle discovery #4787

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

joshuapare
Copy link
Contributor

@joshuapare joshuapare commented Aug 13, 2023

Fixes #3954

Clarify that loki.source.file doesn't handle discovery, and link to the example in the docs that shows usage with the correct component.

  • CHANGELOG.md updated
  • Documentation added

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release-v0.35 labels Aug 15, 2023
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuapare Looks good. Thanks for your input! Merging.

@clayton-cornell clayton-cornell enabled auto-merge (squash) August 15, 2023 12:51
@clayton-cornell clayton-cornell merged commit 883d569 into grafana:main Aug 15, 2023
grafanabot pushed a commit that referenced this pull request Aug 15, 2023
* clarify loki source file doesn't handle discovery

* Update docs/sources/flow/reference/components/loki.source.file.md

Co-authored-by: Clayton Cornell <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 883d569)
clayton-cornell added a commit that referenced this pull request Aug 16, 2023
* clarify loki source file doesn't handle discovery

* Update docs/sources/flow/reference/components/loki.source.file.md

Co-authored-by: Clayton Cornell <[email protected]>

---------

Co-authored-by: Clayton Cornell <[email protected]>
(cherry picked from commit 883d569)

Co-authored-by: Joshua Pare <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
@joshuapare joshuapare deleted the fix-loki-source-file-docs branch August 19, 2023 03:28
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport release-v0.35 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loki.source.file doesn't pick up the file if it's created after the agent starts
2 participants