Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel/prometheus_exporter: disable otel_scope_info by default #4775

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

gouthamve
Copy link
Member

@gouthamve gouthamve commented Aug 10, 2023

The collector doesn't implement this yet and the metrics are not very useful.

See: open-telemetry/opentelemetry-collector-contrib#24248

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

The collector doesn't implement this yet and the metrics are not very useful.

See: open-telemetry/opentelemetry-collector-contrib#24248

Signed-off-by: Goutham <[email protected]>
@gouthamve gouthamve requested review from a team and clayton-cornell as code owners August 10, 2023 10:03
@gouthamve gouthamve changed the title Disable scope_info by default otel/prometheus_exporter: disable otel_scope_info by default Aug 10, 2023
Signed-off-by: Goutham <[email protected]>
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc-ing @ptodev who worked on upgrading our OTel dependency this past week to merge.

@rfratto
Copy link
Member

rfratto commented Aug 10, 2023

I'm not necessarily against the change, but I'm not sure if this is going against the compatibility spec.

The compatibility spec states:

Prometheus exporters SHOULD provide a configuration option to disable the otel_scope_info metric and otel_scope_ labels.

I took this to mean that the configuration option should exist, and should default to true. Did I misunderstand this line?

@clayton-cornell
Copy link
Contributor

I took this to mean that the configuration option should exist, and should default to true. Did I misunderstand this line?

FWIW, I'd interpret this the same way.

Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are OK as-is.

This doesn't account for the clarification of the default status.

@gouthamve
Copy link
Member Author

Kicked off a discussion in OTEL land which led to this: open-telemetry/opentelemetry-specification#3657

Having the metrics switched on by default doesn't provide a lot of value and I think the spec will evolve to disable metrics unless there are attributes.

Should we go ahead and merge this? cc @rfratto

@rfratto rfratto merged commit 388aff7 into grafana:main Aug 15, 2023
6 checks passed
@gouthamve gouthamve deleted the disable-scope-info branch August 15, 2023 14:36
@gouthamve gouthamve restored the disable-scope-info branch August 15, 2023 14:36
@gouthamve gouthamve deleted the disable-scope-info branch August 15, 2023 14:36
@gouthamve gouthamve restored the disable-scope-info branch August 15, 2023 14:37
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants