Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YACE dimension_name_requirements support #4705

Merged
merged 7 commits into from
Aug 10, 2023
Merged

YACE dimension_name_requirements support #4705

merged 7 commits into from
Aug 10, 2023

Conversation

CVdV-au
Copy link
Contributor

@CVdV-au CVdV-au commented Aug 4, 2023

PR Description

Which issue(s) this PR fixes

Fixes #4381

Notes to the Reviewer

Simple config passthrough

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@CVdV-au CVdV-au requested review from a team and clayton-cornell as code owners August 4, 2023 06:39
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

marctc
marctc reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added the changes to flow component and documented the field in the static integration 😄 Could you add documentation for flow component and add the field to the integration? thanks

@CVdV-au CVdV-au requested a review from marctc August 4, 2023 12:29
clayton-cornell
clayton-cornell approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs are OK as-is

@CVdV-au CVdV-au changed the title Cvdv au/yace dimension name requirements YACE dimension_name_requirements support Aug 6, 2023
@clayton-cornell
Copy link
Contributor

@marctc is this one ready to go?

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Aug 9, 2023
@marctc marctc merged commit 4507bfa into grafana:main Aug 10, 2023
7 checks passed
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
@CVdV-au @clayton-cornell
YACE dimension_name_requirements support (#4705)
397dff9
clayton-cornell pushed a commit that referenced this pull request Aug 14, 2023
@CVdV-au @clayton-cornell
YACE dimension_name_requirements support (#4705)
dcd64dd
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clayton-cornell clayton-cornell clayton-cornell approved these changes

@marctc marctc marctc approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for dimensionNameRequirements in YACE configuration
4 participants
@CVdV-au @CLAassistant @clayton-cornell @marctc