-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update image versions and replace the sample traces generator #4637
Conversation
I know this may be a stretch, but can you try replacing |
I also think that this config should be uncommented by default - so that we have all 3 DBs working. You can test Loki with a query like |
@wildum The CLA is struggling because only the second commit in the PR is associated with your GitHub account; you'll need to squash it into one commit (or change the author of the first commit) so the CLA stops complaining. |
Co-authored-by: Mischa Thompson <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
08aa89b
to
ec00012
Compare
environment: | ||
- TOPOLOGY_FILE=/etc/load-generator/load-generator.json | ||
- JAEGER_COLLECTOR_URL=http://agent:14268 | ||
hotrod: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to dogfood xk6-client-tracing like the Tempo repo does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't know about this one. Maybe we can leave this upgrade for another PR, because we've been creeping scope in this one for a bit already.
server: | ||
grpc_server_max_concurrent_streams: 1000 | ||
grpc_server_max_recv_msg_size: 104857600 | ||
grpc_server_max_send_msg_size: 104857600 | ||
http_listen_port: 9009 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we order the sections in the same way as the original file? Will make review and git history easier to browse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work :)
* update image versions and replace the traces generator * replace cortex by mimir and uncomment logs config * flow: Add openstack discovery component (#4606) Co-authored-by: Mischa Thompson <[email protected]> Co-authored-by: Clayton Cornell <[email protected]> * reorder config in mimir.yaml to match previous file --------- Co-authored-by: Marc Tudurí <[email protected]> Co-authored-by: Mischa Thompson <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
* update image versions and replace the traces generator * replace cortex by mimir and uncomment logs config * flow: Add openstack discovery component (#4606) Co-authored-by: Mischa Thompson <[email protected]> Co-authored-by: Clayton Cornell <[email protected]> * reorder config in mimir.yaml to match previous file --------- Co-authored-by: Marc Tudurí <[email protected]> Co-authored-by: Mischa Thompson <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
PR Description
This PR updates the docker compose example:
PR Checklist