forked from OHIF/Viewers
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient rebase Viewer v3.8.0 stable #19
Open
Adithyan-Dinesh-Trenser
wants to merge
32
commits into
upstream_rebase_3-8-0_copy
Choose a base branch
from
gradient_rebase_06212024
base: upstream_rebase_3-8-0_copy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gradient rebase Viewer v3.8.0 stable #19
Adithyan-Dinesh-Trenser
wants to merge
32
commits into
upstream_rebase_3-8-0_copy
from
gradient_rebase_06212024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n studybrowser panel
…ed the segmentation mode template panel from ohif to gradienthealth custom one.
…ed in the stack segmentation feature
… segmentation drop down menu.
…e segmentation file.
…ze, added auto saving status icon, added auto segment and label naming.
…l insegmentation panel and added tooltip.
…hen the Toolbox component rerenders.
…ty and ViewPosition if available
…, this change is redundant and thus reverting.
Adithyan-Dinesh-Trenser
changed the title
Gradient rebase 06212024
Gradient rebase Viewer v3.8.0 stable
Jul 23, 2024
maya-mohan
approved these changes
Jul 23, 2024
'Referenced Volume is missing for the SEG, and stack viewport SEG is not supported yet' | ||
); | ||
if (referencedDisplaySet.isReconstructable) { | ||
const cachedReferencedVolume = cache.getVolume(segDisplaySet.referencedVolumeId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we can include above error message with a slight modification in message here?
if (!cachedReferencedVolume) {
throw new Error(
'Referenced Volume is missing for the SEG'
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.