Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waterfall tooltips and click to restore view #1392

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

yuzawa-san
Copy link
Contributor

@yuzawa-san yuzawa-san commented Oct 28, 2024

  • the waterfall tooltips were misleading when the view changed. they were only accurate for the current view. the solution is to store the view parameters (center, fft center, span) and timestamp to properly construct the tooltip's time and frequency.
  • since that data is now stored, it is pretty easy to restore the view if the user were to click on a point on the waterfall. currently, clicking on the waterfall changes the demod frequency.
  • the datapoints are stored in a vector of structs. the same circular buffer implementation that the waterfall image uses is used as well.
  • the waterfall used to invalidate when the lookback range changed, but since the timestamp is stored for each row that is not needed. also if the DSP was disabled then reenabled, that would seamlessly keep track of the history (with a discontinuity in the timeseries).
  • the only thing which causes the timeseries to invalidate is if the sample rate of the DSP were to change. this is because we cannot faithfully or safely restore the view when a user clicks.
    fixes Add time stamp to waterfall #554

@argilo
Copy link
Member

argilo commented Nov 8, 2024

This seems like a useful feature.

One bug I've noticed: sometimes if I tune away by a large amount (by adjusting the 100 MHz digit, for instance) and then click on the "old" part of the waterfall, nothing happens. I'm not sure yet why it only fails some of the time.

@yuzawa-san
Copy link
Contributor Author

i had to reorder the mousePressEvent logic. clicking near the demod frequency or the low/high of the filter box (even in the waterfall) was falling into those first 3 conditions. the solution was to make the click logic only run when in the waterfall and the existing logic run on the overlay region.

@argilo argilo added the feature label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add time stamp to waterfall
2 participants