Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kDefaultCTSOptions.debug to false #4289

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Mar 12, 2025

This affects running tests with workers. This should affect WPT, but not standalone which sets the options explicitly. It also shouldn't affect Chromium, though it could have something to do with over-logging we've seen in the past.

I did not actually try running the WPT runtime but this should be a safe change.

Issue: #4172 (code originally from PR #2787)


Requirements for PR author:

  • [n/a] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [n/a] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [n/a] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [n/a] Tests are properly located in the test tree.
  • [n/a] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • [n/a] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • [n/a] Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This should affect WPT, but not standalone which sets the options
explicitly. It also shouldn't affect Dawn
(https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/webgpu-cts/test_runner.js)
but could have something to do with over-logging we've seen in the past.

Issue: 4172
Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm though it appears to only be used in workers.

@kainino0x
Copy link
Collaborator Author

lgtm though it appears to only be used in workers.

That's correct, updated summary.

@kainino0x kainino0x enabled auto-merge (squash) March 12, 2025 00:23
@kainino0x kainino0x disabled auto-merge March 12, 2025 00:23
@kainino0x kainino0x enabled auto-merge (squash) March 12, 2025 00:23
@kainino0x kainino0x merged commit bf2c923 into gpuweb:main Mar 12, 2025
1 check passed
@kainino0x kainino0x deleted the debugfalse branch March 12, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants