Vertex state correctness #4109
Merged
Vertex state correctness #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Dec 20, 2024
Refactor these tests so they don't use storage buffers. The tests were using one uniform or storage buffer per vertex attribute. Switched to using just a single uniform buffer. Note: There was a note about increasign the vertex count by +1 in vertex_buffer_used_multiple_times_interleaved. I don't know if that's old because removing the +1 there are a few lines below does not break the test nor generate any validation errors. The reason I needed to remove it was the code that packs the data into a single buffer needed the size of each buffer to match kVertexCount but that particular test was passing +1 in some places and not in others.
This test might break on devices with higher limits but in that case the test should be fixed.
greggman
force-pushed
the
vertex-state-correctness
branch
from
eceff4e to
ed883c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor these tests so they don't use storage buffers.
The tests were using one uniform or storage buffer per
vertex attribute. Switched to using just a single uniform
buffer for all attributes.
Note: There was a note about increasing the vertex count
by +1 in vertex_buffer_used_multiple_times_interleaved.
I don't know if that's old because removing the +1 there
and a few lines below does not break the test nor generate
any validation errors.
The reason I needed to remove it was the code that packs
the data into a single buffer needed the size of each buffer
to match kVertexCount but that particular test was passing
+1 in some places and not in others.