-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen Viewport validation tests to match spec update #4106
base: main
Are you sure you want to change the base?
Conversation
97cc6e5
to
bd72ec3
Compare
bd72ec3
to
3a0c2ea
Compare
src/webgpu/api/validation/encoding/cmds/render/dynamic_state.spec.ts
Outdated
Show resolved
Hide resolved
I'll mark it as draft to prevent it from being merged accidentally. |
src/webgpu/api/validation/encoding/cmds/render/dynamic_state.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/encoding/cmds/render/dynamic_state.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/encoding/cmds/render/dynamic_state.spec.ts
Outdated
Show resolved
Hide resolved
{ om: -2, od: -1, sd: 0 }, | ||
{ om: 1, od: 0, sd: 0 }, | ||
{ om: 1, od: 1, sd: -1 }, | ||
{ om: 1, od: -0.1, sd: 0 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each of these we should ideally test two cases that are just an epsilon apart, one valid and one invalid. (see nextAfterF32
in math.ts
)
and in order to make it clear that those test cases are actually doing what we expect, it would help to put _success
as a parameter, instead of computing it in the test
Should not be landed until gpuweb/gpuweb#5025 has been merged into the spec.
Updates the viewport validation tests to match the new behavior that allows viewports to extend beyond the render attachment bounds.
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.