op: Implement 'filter_mode,minFilter' test in filter_mode.spec.ts #2090
Conversation
Gyuyoung
force-pushed
the
filter-mode-minFilter
branch
from
48368fb to
73cf468
Compare
|
Previews, as seen when this build job started (48368fb): |
|
Previews, as seen when this build job started (73cf468): |
This PR adds a new test to test that mipmapFilter affects drawing the slanted plane with different filter modes. Issue: gpuweb#2070
Gyuyoung
force-pushed
the
filter-mode-minFilter
branch
from
73cf468 to
13d9899
Compare
|
Previews, as seen when this build job started (13d9899): |
|
|
||
| export const g = makeTestGroup(SamplerFilterModeSlantedPlaneTest); | ||
|
|
||
| g.test('mipmapFilter') |
There was a problem hiding this comment.
Hmm, I couldn't find a proper way to test the filter modes yet. I aimed to write a test that filter mode affected the expected colors in drawing the slanted plane. But, the filter modes(mipmapFilter first for now) didn't affect the expected result. Could you please give me any idea or comment on how to test the fooFilter affects the expected color?
There was a problem hiding this comment.
It would be useful to visualize the colorAttachment. Unfortunately we never managed to add good facilities for this - I think I started writing some but never finished.
When running in a browser, you can hack in code to visualize it, e.g. add a canvas to the document.body and change drawSlantedPlane to get its attachment from getCurrentTexture instead of createTexture. Example:
Gyuyoung/cts@filter-mode-minFilter...kainino0x:cts:example-visualization
Here you can see there is a slight difference in the result (but it's subtle):
linear
nearest
There was a problem hiding this comment.
Thank you for giving me more information. I don't find a way to test it yet. Let me take a look at this more.
This PR adds a new test to ensure that the operation of minFilter works as expected.
Issue: #2023
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.