added backwards compat support and resolved issue with 3.11 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on why this is relevant: fastapi/typer#371 I digress, I booted it up and it failed so I shared my fix :) |
slapglif
commented
Jun 22, 2023
| @@ -12,7 +13,7 @@ | |||
| @app.command() | |||
| def main( | |||
| messages_path: str, | |||
| out_path: str | None = None, | |||
| out_path: Union[str, None] = None, | |||
There was a problem hiding this comment.
I suppose I would point out, isnt this a bit redundant? Optional[str] by its self works fine but if you need the field set then theres two best practices here:
Optional[str] = None # gives us a default value of None for the field, is polymorphic.Optional[str] = Field(...) # gives us a default of None with an enforced str type validation - all classes should be dataclasses anyway right?
|
Thanks @slapglif I just merged this from another PR, thanks anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my pull request, I made changes to the main function in order to address an error. I modified the function signature by changing the type hint for the out_path parameter. Originally, it was annotated as str | None, which uses the union operator. However, this syntax is not compatible with older versions of Python. To make it compatible, I replaced it with Union[str, None] using the typing.Union class. This change ensures that the code can be executed in Python versions prior to 3.10. You can review the specific modifications I made, should not effect anything downstream.