PTP symbol naming #1037
Merged
PTP symbol naming #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terms ObjectCompressedSize and ThumbCompressedSize come from the PTP specification. But I find them to be overly verbose because there is no other size than this "compressed" size. Other places like the CameraFileInfoFile struct also use the term "size" instead of "compressed_size" for the same thing.
There are lots of other symbols like GetDevicePropValue that use the short version "PropValue" already. Also the variables of this type are also most often called "propval".
The PTPDeviceInfo struct contains information about the Operations, Events, DeviceProperties, ImageFormats and CaptureFormats. With 3 of those 5 the variables contained the additional "Supported" string, which does not add any discriminating value and only makes for very long and therefore less readable code lines and it is inconsistent. Also use the term "DeviceProps" here as well for brevity and consistency.
The "_len"-suffix to denote the length of an array of values is more readable than the "nrof"-prefix and also used 3 times more often in the rest of the code base. Also replace the params->deviceproperties name with params->dpd_cache to make it clearer what it actually is: an array of cached DevicePropDesc structs.
... to be consistent with specification and also with the names of similar symbols in the rest of the code.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a whole bunch of rather trivial renaming patches with the goals to:
If I didn't screw up, this is only changing names of symbols and fixes whitespace where affected. It does not change the
behavior of the code in any way.