fix: add laminas/laminas-feed package to support aggregator
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple projects use the `aggregator` module from this repository, but the image is missing the `laminas/laminas-feed` composer package, thereby failing the commands that use the module. Adding this package should fix this issue.
yusufhm
force-pushed
the
bugfix/missing-laminas-feed-composer-package
branch
from
6f96b30
to
5b5bab8
Compare
|
Tested using the following: $ docker buildx bake -f docker-compose.yml -f docker-compose.override.yml cli
...
...
=> => naming to docker.io/govcms/govcms:10.x-edge
$ docker run --rm -it govcms/govcms:10.x-edge bash -c "composer why laminas/laminas-feed"
configured lagoon-php.ini
govcms/lagoon - requires laminas/laminas-feed (^2.17)I had also tested previously that it fixes the cron runs for two projects which use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple projects use the
aggregatormodule from this repository, but the image is missing thelaminas/laminas-feedcomposer package, thereby failing the commands that use the module. Adding this package should fix this issue.