Skip to content

Conversation

balapal
Copy link

@balapal balapal commented Nov 28, 2018

Hi,

I have just added PageScroll component to my Tapestry App.
The first scroll triggered data retrieval works fine and shows the result properly.
However the second scroll data retrieval is broken. It is not appending the returned HTML elements, but replaces first scroll triggered section.

I managed to fix it in my app, by overriding the PageScroll.js as below, however it is not working in PageScrollTest.java due to not finding $ in activeZone.$.clone().
It work in my pure jQuery app, but it seems that this test page is also loading prototype and for some reason not exposing $ via ElementWrapper.
I am not sure how to overcome this challenge. Could you please advise.

… test AppModule to not to include prototype.js included and such make the PageScroll component test work
@balapal
Copy link
Author

balapal commented Dec 1, 2018

I have changed the JAVASCRIPT_INFRASTRUCTURE_PROVIDER to "jquery" in test AppModule, so the tests pass now locally

@balapal
Copy link
Author

balapal commented Feb 24, 2019

Hi @got5,
Do you guys need anything else to have this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant