fix: broken annotated commit detection #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickajacks1
force-pushed
the
annotated-commit
branch
from
6781930 to
956081f
Compare
|
Removed files accidentally added to branch |
|
do we need all these example hook files? thanks for the PR btw :) |
Annotated commits have their own object hash in addition to the commit hash. gitRepo.Tag() returns the hash of the tag instead of the commit. If this resulting hash is passed to CommitsBetween, as is done in `chglog add`, the hash will never be found. Update GitHashFotTag to return the commit hash if the tag is an annotated tag. This fixes an issue where `chglog add` adds the entire git history when annotated tags are used.
nickajacks1
force-pushed
the
annotated-commit
branch
from
956081f to
06cc0e7
Compare
|
Probably not. I just based it off what was already there. Removed the files. Thanks for looking at this! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 25.23% 26.40% +1.17%
==========================================
Files 15 15
Lines 650 659 +9
==========================================
+ Hits 164 174 +10
+ Misses 464 462 -2
- Partials 22 23 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotated commits have their own object hash in addition to the commit hash. gitRepo.Tag() returns the hash of the tag instead of the commit. If this resulting hash is passed to CommitsBetween, as is done in
chglog add, the hash will never be found. Update GitHashFotTag to return the commit hash if the tag is an annotated tag.This fixes an issue where
chglog addadds the entire git history when annotated tags are used.