Add ability to disable ending editing on resize #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a comment editor which presents as a persistent bottom sheet. I was finding that when I drag between detents, my text field was being forced to resign its responder, which is bad. There was also a visual bug where the sheet would be the wrong height during the drag due to its offsets being computed with the keyboard up.
Rather than removing the behavior for all users, I added a config option, but I'm not convinced it's better than simply removing the call to
endEditing(). It would be better to have some kind of configurable callback so users can choose to end editing if it makes sense for their use case. What do you think?This line was added a very long time ago, maybe you have some context you can share @gordontucker?