Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: panGestureShouldBegin should be checked first #207

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: panGestureShouldBegin should be checked first #207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8611748
fix: panGestureShouldBegin should be checked first
ChitlangeSahas Jul 4, 2023
a8d8bad
Merge branch 'gordontucker:main' into main
ChitlangeSahas Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions FittedSheets/SheetViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,12 +715,13 @@ extension SheetViewController: UIGestureRecognizerDelegate {
}

public func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool {
guard let panGestureRecognizer = gestureRecognizer as? InitialTouchPanGestureRecognizer, let childScrollView = self.childScrollView, let point = panGestureRecognizer.initialTouchLocation else { return true }

if let pan = gestureRecognizer as? UIPanGestureRecognizer, let closure = panGestureShouldBegin, let should = closure(pan) {
return should
}

guard let panGestureRecognizer = gestureRecognizer as? InitialTouchPanGestureRecognizer, let childScrollView = self.childScrollView, let point = panGestureRecognizer.initialTouchLocation else { return true }


let pointInChildScrollView = self.view.convert(point, to: childScrollView).y - childScrollView.contentOffset.y

let velocity = panGestureRecognizer.velocity(in: panGestureRecognizer.view?.superview)
Expand Down