Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: registering flusher listener to be based on kernel.terminate #39

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix: registering flusher listener to be based on kernel.terminate #39

merged 2 commits into from
Jul 29, 2024

Conversation

juniorb2ss
Copy link
Contributor

Closes #38

@gordalina
Copy link
Owner

gordalina commented Jul 17, 2024 •
edited
Loading

Can you rebase this on current master? 🙏 The ci checks are now fixed.

@juniorb2ss
Copy link
Contributor Author

Done @gordalina. Thank you!

@gordalina gordalina merged commit 026982d into gordalina:master Jul 29, 2024
8 checks passed
@gordalina
Copy link
Owner

Released in 5.1.0. Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flusher::flush should be called on kernel.terminate event instead of kernel.finish_request
2 participants
@juniorb2ss @gordalina