Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flusher::flush should be called on kernel.terminate event instead of kernel.finish_request #38

Closed
juniorb2ss opened this issue Jul 5, 2024 · 0 comments · Fixed by #39
Closed

Flusher::flush should be called on kernel.terminate event instead of kernel.finish_request #38

juniorb2ss opened this issue Jul 5, 2024 · 0 comments · Fixed by #39

Comments

@juniorb2ss
Copy link
Contributor

Currently, the listener FinishRequestListener is being registered for kernel.finish_request event, which can cause a overhead when handling requests as you can see:

CleanShot 2024-07-04 at 19 03 26

I think it should be based on KernelTerminate event.

Typical Purposes: To perform some "heavy" action after the response has been streamed to the user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: registering flusher listener to be based on kernel.terminate juniorb2ss/GordalinaMixpanelBundle
1 participant
@juniorb2ss