Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssa: fix wrong reflect type of closure #874

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

cpunion
Copy link
Contributor

@cpunion cpunion commented Nov 24, 2024

Fix #864 (call closure failed)

Fix #832 (wrong reflect type of closure):

➜  llgo git:(fix-closure) ✗ go run ./_demo/reflectfunc
func(int, int) int
func
func(int, int) int
func
➜  llgo git:(fix-closure) ✗ go run ./cmd/llgo run ./_demo/reflectfunc
# github.com/goplus/llgo/cmd/llgo
ld: warning: -ld_classic is deprecated and will be removed in a future release
func(...)
func
func(...)
func

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (e042aad) to head (252f3f0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          22       22           
  Lines        6230     6233    +3     
=======================================
+ Hits         5952     5955    +3     
  Misses        246      246           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@cpunion cpunion changed the title ssa: fix closure ssa: fix wrong reflect type of closure Nov 24, 2024
@xushiwei xushiwei merged commit 8d2b653 into goplus:main Nov 25, 2024
10 checks passed
@cpunion cpunion deleted the fix-closure branch November 25, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: unreachable: 20(*types.Struct) when returns closure in closure Wrong reflect type of function
2 participants