Skip to content

Commit

Permalink
Merge pull request #369 from xushiwei/q
Browse files Browse the repository at this point in the history
library: strconv
  • Loading branch information
xushiwei authored Jun 20, 2024
2 parents 1f04c61 + f7d7f81 commit 870dde2
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 12 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ Here are the Go packages that can be imported correctly:
* [math](https://pkg.go.dev/math)
* [math/bits](https://pkg.go.dev/math/bits)
* [math/cmplx](https://pkg.go.dev/math/cmplx)
* [strconv](https://pkg.go.dev/strconv)
* [syscall](https://pkg.go.dev/syscall) (partially)
* [sync](https://pkg.go.dev/sync) (partially)
* [sync/atomic](https://pkg.go.dev/sync/atomic) (partially)
Expand Down
7 changes: 7 additions & 0 deletions _demo/strconv/strconv.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package main

import "strconv"

func main() {
println(strconv.Itoa(-123))
}
9 changes: 7 additions & 2 deletions cl/import.go
Original file line number Diff line number Diff line change
Expand Up @@ -518,10 +518,15 @@ func ignoreName(name string) bool {
return true
}
*/
return strings.HasPrefix(name, "internal/") || strings.HasPrefix(name, "crypto/") ||
return (strings.HasPrefix(name, "internal/") && !supportedInternal(name)) ||
strings.HasPrefix(name, "crypto/") || strings.HasPrefix(name, "reflect.") ||
strings.HasPrefix(name, "arena.") || strings.HasPrefix(name, "maps.") ||
strings.HasPrefix(name, "time.") || strings.HasPrefix(name, "runtime/") ||
strings.HasPrefix(name, "plugin.") || strings.HasPrefix(name, "reflect.")
strings.HasPrefix(name, "plugin.")
}

func supportedInternal(name string) bool {
return strings.HasPrefix(name, "internal/bytealg.")
}

// -----------------------------------------------------------------------------
Expand Down
24 changes: 14 additions & 10 deletions internal/build/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -726,6 +726,9 @@ func decodeFile(outFile string, zipf *zip.File) (err error) {
}

func canSkipToBuild(pkgPath string) bool {
if _, ok := hasAltPkg[pkgPath]; ok {
return false
}
switch pkgPath {
case "unsafe":
return true
Expand All @@ -738,16 +741,17 @@ func canSkipToBuild(pkgPath string) bool {
type none struct{}

var hasAltPkg = map[string]none{
"errors": {},
"io": {},
"io/fs": {},
"math": {},
"math/cmplx": {},
"sync": {},
"sync/atomic": {},
"syscall": {},
"os": {},
"runtime": {},
"errors": {},
"internal/bytealg": {},
"io": {},
"io/fs": {},
"math": {},
"math/cmplx": {},
"sync": {},
"sync/atomic": {},
"syscall": {},
"os": {},
"runtime": {},
}

func check(err error) {
Expand Down
22 changes: 22 additions & 0 deletions internal/lib/internal/bytealg/bytealg.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/*
* Copyright (c) 2024 The GoPlus Authors (goplus.org). All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package bytealg

// llgo:skip init
import (
_ "unsafe"
)

0 comments on commit 870dde2

Please sign in to comment.