Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#96 Preliminary command completion #111

Closed
wants to merge 2 commits into from
Closed

#96 Preliminary command completion #111

wants to merge 2 commits into from

Conversation

AdeshAtole
Copy link

Description

To add command completion for bash.

Fixes/Implements: #96

Checklist:

  • My code follows the style guidelines – pep8 of this project
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog draft for corresponding release
  • I have update README (If needed)

@pep8speaks
Copy link

pep8speaks commented Jul 6, 2019 •
edited
Loading

Hello @AdeshAtole! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 45:1: W293 blank line contains whitespace

Comment last updated at 2019-07-15 09:04:59 UTC

@AdeshAtole
Copy link
Author

@gopinath-langote @landpro

This is not ready to merge yet. I have experimented with this approach. Let me know what you think.

@gopinath-langote
Copy link
Owner

Moved to golang from python, so this PR is no more valid.

Thank you @AdeshAtole for the efforts. Feel free to implement same in golang

@AdeshAtole
Copy link
Author

@gopinath-langote Closing the PR.

@AdeshAtole AdeshAtole closed this Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdeshAtole @pep8speaks @gopinath-langote