Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for 1build #96

Open
AdeshAtole opened this issue Jun 13, 2019 · 4 comments
Open

Add bash completion for 1build #96

AdeshAtole opened this issue Jun 13, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed new_feature New features

Comments

@AdeshAtole
Copy link

AdeshAtole commented Jun 13, 2019

Description

We can have command completion for commands in 1build.yaml
Would help improving productivity

Acceptance Criteria

Command completion for commands defined in 1build.yaml (for bash to start with)

Notes

https://github.com/spf13/cobra/blob/master/bash_completions.md

@gopinath-langote
Copy link
Owner

Does it include suggesting multiple commands or a user has to type enough letters for us to define a single command and then it is displayed?

Example – I type 1build and hit a tab – it displays a full list of commands and then optionally I can navigate through them with the tab. Or I type 1build b and it completes to 1build build because it is the only command starting with B letter.

We can also choose to move iteratively with the end goal of those suggested multiple options.

@gopinath-langote gopinath-langote added the new_feature New features label Jun 14, 2019
@AdeshAtole
Copy link
Author

@gopinath-langote

I type 1build and hit a tab – it displays a full list of commands and then optionally I can navigate through them with the tab. Or I type 1build b and it completes to 1build build because it is the only command starting with B letter.

Both cases, except for navigating through them using tab. If user has typed enough characters to distinguish the command, it will get completed, else matching commands will be shown.

We can start with bash and then extend support to other shells if needed.

@AdeshAtole
Copy link
Author

@gopinath-langote @landpro Let me know if I can pick this up

@gopinath-langote
Copy link
Owner

@AdeshAtole Thanks for feature suggestion.
this feature is important and very useful for developers.

feel free to open the PR.

@gopinath-langote gopinath-langote added the In Progress Someone working on the issue label Jun 16, 2019
AdeshAtole added a commit to AdeshAtole/1build that referenced this issue Jul 6, 2019
@gopinath-langote gopinath-langote added enhancement New feature or request good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed and removed In Progress Someone working on the issue labels Sep 12, 2019
@gopinath-langote gopinath-langote pinned this issue Sep 12, 2019
@gopinath-langote gopinath-langote changed the title Add command completion for bash Add bash completion for 1build Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed new_feature New features
Projects
None yet
Development

No branches or pull requests

2 participants