Repository navigation
Preserve updated values when exporting environment settings - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Loading
value = ${TOKEN|old}and thenvalue = replacementupdatesGet, butWriteToexports the old expression. Reloading that output restoresold.Discard cached expressions when values or sections change. Cache entries use both the section name and key, so names such as
a_b.canda.b_ccannot collide. Export uses a copy of the data to preserve untouched expressions without changing current values.The tests cover each update method and deletion. They also check case handling, rejected writes and colliding names. The original code fails the replacement regressions.
Validation: the full suite and race checks pass. Build and vet pass with Go 1.19.13, which also passes the suite. Staticcheck reports the same 131 existing diagnostics as the baseline. Golint reports its existing
EncodeOptionscomment warning.