Update API Executable Example to use deploymentId instead of scriptId#1750
Update API Executable Example to use deploymentId instead of scriptId#1750vineetsahu-boop wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
Update `scripts.run` documentation to use `deploymentId` instead of `scriptId`. The `scripts.run` method now requires a `deploymentId` in the request path and path parameters, replacing the previous use of `scriptId`. The description for finding the ID has also been updated.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the sample code for the Google Apps Script API to align with a recent change in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the sample code to use deploymentId instead of scriptId for executing an Apps Script, aligning with a recent API change. The changes are straightforward and reflect the description. I have included one review comment regarding comment formatting to enhance readability, adhering to the project's style guidelines.
| // Deployment ID of the script to call. Acquire this from | ||
| // the Apps Script editor, under Publish > Deploy as API executable. |
There was a problem hiding this comment.
The line wrapping in this comment is awkward and there is a trailing space on line 99, which harms readability. The repository's style guide prefers the Google Java Style Guide, which emphasizes code readability. I suggest re-wrapping the comment for better clarity.
| // Deployment ID of the script to call. Acquire this from | |
| // the Apps Script editor, under Publish > Deploy as API executable. | |
| // Deployment ID of the script to call. Acquire this from the Apps Script editor, | |
| // under Publish > Deploy as API executable. |
References
- The repository style guide (line 7) states a preference for Google's style guides, which prioritize code readability and consistent formatting. The current comment wrapping and trailing whitespace do not align with these best practices. (link)
Update
scripts.rundocumentation to usedeploymentIdinstead ofscriptId.The
scripts.runmethod now requires adeploymentIdin the request path and path parameters, replacing the previous use ofscriptId. The description for finding the ID has also been updated.Description
Update sample code to use
deploymentIdinstead ofscriptId.The run method now requires a
deploymentIdin the request path and path parameters, replacing the previous use ofscriptId. The description for finding the ID has also been updated.Fixes # (issue)
Is it been tested?
Checklist