Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change iOS plugin so compiles for Xcode 11 #119

Closed
wants to merge 1 commit into from

Conversation

marchinram
Copy link

Also remove parse dependency not needed and set presenting view controller

@ragavendranbala
Copy link

Does it works on android also? Or need to use the official release only?

@marchinram
Copy link
Author

Yeah I use it for both, Android wasn't causing me any issues, only the generated Xcode project had errors

@ragavendranbala
Copy link

Can you tell me how to download your pull request to fix the iOS issue on my project?

@marchinram
Copy link
Author

You just run the build script sh build_all.sh I tried and saw a problem with the script will look into this

@marchinram
Copy link
Author

Should work ok my only issue was I didn't set the UNITY_EXE env variable to the location of Unity executable, e.g: /Applications/Unity/Hub/Editor/2019.2.10f1/Unity.app/Contents/MacOS/Unity, after it's complete produces 2 .unitypackage files, google-signin-plugin-1.0.4.unitypackage and GoogleSignIn-sample.unitypackage, lemme know if you have issues with this @ragavendranbala

@marchinram
Copy link
Author

handled here: #126

@marchinram marchinram closed this Sep 28, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants