-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PointCloud Example Scene #33
New PointCloud Example Scene #33
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@petpetpeter How does that differ from the existing raw point cloud generation example? Do you create a mesh from the points? An example screenshot or similar would be great |
The existing PointCloudGenerator script creates a list of vertices no the button callback When using Raw Depth, I found that it crashes on my devices (Pixel4a and Mi 9) and seem to be very slow on a better smartphone according to #29 (comment) The newly updated RawPointCloudBlender script buffers the vertices before updating the vertex. So, it would be great if the PointCloudGeneration Example uses a similar method. |
I'm testing and reviewing this one. Thank you for the patience. |
Hey petpetpeter, Sorry for the late reply, as I could not get any point clouds from your PR on Wednesday and I tried again on this Friday, both using Pixel 4, Unity 2019.4.22f1. For both tests, I copied the 4 files without any modification, then added opened scenes as the only scene to build. The update button shows, but I cannot get any feedback. In contrast, my raw point cloud scene runs when set as the only scene to build. Sorry that I don't have much time to debug, as I have some life events next week. Would you please double check your PR and make sure it runs? Cheers, |
@ruofeidu My bad. I didn't copy the meta files so the script is missing from the inspector. Now, I test by replacing the whole PointCloud folder from PR with the original andriod-sdk branch in a new project. In case it is more convenient for you, Sorry for your inconvenient, Please take your time 👍 |
Thank you petpetpeter for the update! I'll test it early next week :) Have a great weekend! |
from: #29 (comment)
I added a new PointCloudGeneration scene and script using a similar pointcloud generation code to RawPointCloudBlender.