fix: Fixes an edge case and formatting.#1450
Open
willum070 wants to merge 5 commits into
Open
Conversation
willum070
force-pushed
the
fix-3d-camera-position
branch
from
d05b57c to
cf4c1c0
Compare
willum070
changed the title
Removing since it's impossible to get a negative value here.
chrisjshull
approved these changes
May 12, 2026
| > | ||
| <label for="tilt"> | ||
| Tilt: <span id="tilt-val">45</span>° | ||
| </label> |
Contributor
There was a problem hiding this comment.
non-blocking - but there are a few other cases of this in this file, if you want
| altitude: currentCenter.altitude, | ||
| }; | ||
| } | ||
| } else if (prop === 'altitude') { |
Contributor
There was a problem hiding this comment.
seeing as there is an established "special case" pattern see with eh if-elses, consider instead handling tilt in that way
...
else if (prop === 'tilt') {
map3DElement.tilt = Math.max(0, val);
} else ...
and leave the final else as a purely generic catch-all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following things: