Skip to content

feat: modernize Kotlin snippets module with capabilities and visual test suites #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkhawk wants to merge 1 commit into from
Open

feat: modernize Kotlin snippets module with capabilities and visual test suites #2427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,8 @@ jobs:

- name: Build and check
run: |
./gradlew :snippets:kotlin-app:assembleDebug
./gradlew :snippets:java-app:assembleDebug
./gradlew :snippets:app-ktx:assembleDebug
./gradlew :snippets:app-utils-ktx:assembleDebug
./gradlew :snippets:app-compose:assembleDebug
./gradlew :snippets:app-places-ktx:assembleDebug

Expand Down
21 changes: 7 additions & 14 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,9 @@ jobs:
./gradlew :ApiDemos:kotlin-app:lintDebug
./gradlew :ApiDemos:java-app:lintDebug
./gradlew :ApiDemos:common-ui:lintDebug
./gradlew :snippets:kotlin-app:lintDebug
./gradlew :snippets:java-app:lintDebug
./gradlew :snippets:app-utils-ktx:lintDebug
./gradlew :snippets:app-places-ktx:lintDebug
./gradlew :snippets:app-ktx:lintDebug
./gradlew :snippets:app-compose:lintDebug
./gradlew :WearOS:Wearable:lintDebug
./gradlew :FireMarkers:app:lintDebug
Expand All @@ -81,30 +80,24 @@ jobs:
sarif_file: ApiDemos/project/common-ui/build/reports/lint-results-debug.sarif
category: ApiDemos-common-ui

- name: Upload SARIF for snippets:java-app
- name: Upload SARIF for snippets:kotlin-app
uses: github/codeql-action/upload-sarif@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
with:
sarif_file: snippets/java-app/build/reports/lint-results-debug.sarif
category: snippets-java-app
sarif_file: snippets/kotlin-app/build/reports/lint-results-debug.sarif
category: snippets-kotlin-app

- name: Upload SARIF for snippets:app-utils-ktx
- name: Upload SARIF for snippets:java-app
uses: github/codeql-action/upload-sarif@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
with:
sarif_file: snippets/app-utils-ktx/build/reports/lint-results-debug.sarif
category: snippets-app-utils-ktx
sarif_file: snippets/java-app/build/reports/lint-results-debug.sarif
category: snippets-java-app

- name: Upload SARIF for snippets:app-places-ktx
uses: github/codeql-action/upload-sarif@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
with:
sarif_file: snippets/app-places-ktx/build/reports/lint-results-debug.sarif
category: snippets-app-places-ktx

- name: Upload SARIF for snippets:app-ktx
uses: github/codeql-action/upload-sarif@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
with:
sarif_file: snippets/app-ktx/build/reports/lint-results-debug.sarif
category: snippets-app-ktx

- name: Upload SARIF for snippets:app-compose
uses: github/codeql-action/upload-sarif@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
with:
Expand Down
6 changes: 2 additions & 4 deletions settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,8 @@ include(":snippets:common")
project(":snippets:common").projectDir = file("snippets/common")
include(":snippets:java-app")
project(":snippets:java-app").projectDir = file("snippets/java-app")
include(":snippets:app-ktx")
project(":snippets:app-ktx").projectDir = file("snippets/app-ktx")
include(":snippets:app-utils-ktx")
project(":snippets:app-utils-ktx").projectDir = file("snippets/app-utils-ktx")
include(":snippets:kotlin-app")
project(":snippets:kotlin-app").projectDir = file("snippets/kotlin-app")
include(":snippets:app-compose")
project(":snippets:app-compose").projectDir = file("snippets/app-compose")
include(":snippets:app-places-ktx")
Expand Down
1 change: 0 additions & 1 deletion snippets/app-ktx/.gitignore
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions snippets/app-ktx/proguard-rules.pro
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions snippets/app-ktx/src/main/AndroidManifest.xml
View file
Open in desktop

This file was deleted.

68 changes: 0 additions & 68 deletions snippets/app-ktx/src/main/java/com/example/app_ktx/KTX.kt
View file
Open in desktop

This file was deleted.

46 changes: 0 additions & 46 deletions snippets/app-ktx/src/main/res/drawable-v24/ic_launcher_foreground.xml
View file
Open in desktop

This file was deleted.

Loading
Loading