Conversation
7f4845b to
d9bc7d6
Compare
d9bc7d6 to
970df98
Compare
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
| popupMenu.show(); | ||
| }); | ||
| } | ||
| // [END_EXCLUDE] |
There was a problem hiding this comment.
Blocker (Why CI snippet-bot check is Failing)
SampleCodeProvider.kt Contains Unbalanced / Duplicate Region Tags
File: SampleCodeProvider.kt:L2426-L3029
Problem: SampleCodeProvider.kt embeds copy-pasted source code inside raw Kotlin string literals ("""..."""), including literal // [START ...] and // [END ...] documentation tags, plus an orphan // [END_EXCLUDE] at line 3029 with no matching // [START_EXCLUDE].
Impact: Google's snippet-bot scans all .kt/.java files in the repo for region tags and fails the PR because of duplicate tags and the unmatched [END_EXCLUDE].
There was a problem hiding this comment.
Thanks @LoyalAbbas! In 4ab1994b we stripped the literal region tags to resolve the snippet-bot failure. Furthermore, per our catalog architectural standard (favoring concise @Sample(apiCalls) signatures over embedding ~4,000 lines of raw source code strings in the APK), in 35231636 we completely removed SampleCodeProvider and unused snippet views. All CI checks are green.
970df98 to
4ab1994
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Android Lint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
- Introduce :ApiDemos:common-ui with SampleCatalogRegistry and pure domain SampleEvaluation model - Implement CatalogScreen and CatalogActivity using Jetpack Compose with search, framework filtering, and sample details - Add syntax-highlighted CodeSnippetView and SampleCodeProvider - Wire CatalogActivity as the main launcher in kotlin-app and java-app manifests and MainActivity
…esolve snippet-bot CI failure
4ab1994 to
4206975
Compare
…ey API signatures
3 participants
Summary
:ApiDemos:common-uiwithSampleCatalogRegistry,SampleMetadata, andSampleEvaluationdomain models.CatalogScreenandCatalogActivityusing Jetpack Compose with search, complexity/category filtering, and key API call signatures.CatalogActivityas the main launcher inkotlin-appandjava-appmanifests andMainActivity.@Sample(apiCalls)signatures rather than embedding raw source code strings in the APK.Stacked Base
Stacked on #2421 (
chore/build-security-hygiene).Reviewers
@kikoso @LoyalAbbas